Hi hch, The patchset looks good, although I'm not quite familiar with the reflink code so, I apologize if it is a stupid question After enabling the reflink feature during mount time, I believe this will not have any problems in future mounts of this filesystem without reflink support? > index 84348af..dfa5077 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -82,7 +82,7 @@ enum { > Opt_quota, Opt_noquota, Opt_usrquota, Opt_grpquota, Opt_prjquota, > Opt_uquota, Opt_gquota, Opt_pquota, > Opt_uqnoenforce, Opt_gqnoenforce, Opt_pqnoenforce, Opt_qnoenforce, > - Opt_discard, Opt_nodiscard, Opt_dax, Opt_err, > + Opt_discard, Opt_nodiscard, Opt_reflink, Opt_dax, Opt_err, > }; > > static const match_table_t tokens = { > @@ -132,6 +132,7 @@ static const match_table_t tokens = { > {Opt_qnoenforce, "qnoenforce"}, /* same as uqnoenforce */ > {Opt_discard, "discard"}, /* Discard unused blocks */ > {Opt_nodiscard, "nodiscard"}, /* Do not discard unused blocks */ > + {Opt_reflink, "reflink"}, /* Do not discard unused blocks */ ^^^^ Also, I believe this comment is wrong!? Cheers -- Carlos _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs