On Tue, May 03, 2016 at 11:02:19AM -0400, Brian Foster wrote: > > Because the interface from the core iomap code need to pass the > > length of the actually mapped range, and the amount of bytes successfully > > written into it to the filesystem, as other filesystems will require > > this for their locking. We need to convert it back at some point, > > and it seems more logical here than in the caller. > > > > I'm not asking about the interface... or at least I'm not following your > point. I'm just suggesting that the calculation of end_fsb is wrong. > E.g., if the intent is to punch out the range that was allocated but not > written to, shouldn't the range to punch be [offset + written, offset + > length]? Oh, yes. It probably should - let me fix it and re-run xfstests.. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
