Dan Williams <dan.j.williams@xxxxxxxxx> writes: >>> There's a lot of special casing here, so you might consider adding >>> comments. >> >> Correct - maybe we should reconsider wrapper-izing this? :) > > Another option is just to skip dax_do_io() and this special casing > fallback entirely if errors are present. I.e. only attempt dax_do_io > when: IS_DAX() && gendisk->bb && bb->count == 0. So, if there's an error anywhere on the device, penalize all I/O (not just writes, and not just on sectors that are bad)? I'm not sure that's a great plan, either. -Jeff _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
