Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vishal,

[auto build test WARNING on linux-nvdimm/libnvdimm-for-next]
[also build test WARNING on v4.6-rc1 next-20160329]
[cannot apply to xfs/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Vishal-Verma/dax-handling-of-media-errors/20160330-100409
base:   https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-for-next
config: x86_64-randconfig-i0-03300245 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   fs/ext4/indirect.c: In function 'ext4_ind_direct_IO':
>> fs/ext4/indirect.c:719:11: warning: 'ret_saved' may be used uninitialized in this function [-Wmaybe-uninitialized]
      ssize_t ret_saved = 0;
              ^

vim +/ret_saved +719 fs/ext4/indirect.c

   703			smp_mb();
   704			if (unlikely(ext4_test_inode_state(inode,
   705							    EXT4_STATE_DIOREAD_LOCK))) {
   706				inode_dio_end(inode);
   707				goto locked;
   708			}
   709			if (IS_DAX(inode))
   710				ret = dax_do_io(iocb, inode, iter, offset,
   711						ext4_dio_get_block, NULL, 0);
   712			else
   713				ret = __blockdev_direct_IO(iocb, inode,
   714							   inode->i_sb->s_bdev, iter,
   715							   offset, ext4_dio_get_block,
   716							   NULL, NULL, 0);
   717			inode_dio_end(inode);
   718		} else {
 > 719			ssize_t ret_saved = 0;
   720	
   721	locked:
   722			if (IS_DAX(inode)) {
   723				ret = dax_do_io(iocb, inode, iter, offset,
   724						ext4_dio_get_block, NULL, DIO_LOCKING);
   725				if (ret == -EIO && iov_iter_rw(iter) == WRITE)
   726					ret_saved = ret;
   727				else

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux