Re: [PATCH 02/19] mkfs: sanitise ftype parameter values.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 24, 2016 at 5:33 PM, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:


On 3/24/16 6:15 AM, jtulak@xxxxxxxxxx wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> Because passing "-n ftype=2" should fail.

but passing crc=1 ftype=1 shouldn't fail, should it?
Seems like it will here.

​From man page:
When  CRCs are enabled via -m crc=1, the ftype functionality is always enabled. This feature can not be
​ 
turned off for such filesystem configurations.​
 

​So I think it should not be possible to enter both crc and ftype at the same time - which is the current behaviour. It feels strange a bit to allow ftype=1 (which does nothing with crc=1), but fail on ftype=0​

​Jan​


--
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux