> @@ -478,7 +478,8 @@ xfs_inode_item_unpin( > STATIC uint > xfs_inode_item_push( > struct xfs_log_item *lip, > - struct list_head *buffer_list) > + struct list_head *buffer_list) __releases(&lip->li_ailp->xa_lock) > + __acquires(&lip->li_ailp->xa_lock) Can you move these down a bit? Something like: struct list_head *buffer_list) __releases(&lip->li_ailp->xa_lock) __acquires(&lip->li_ailp->xa_lock) { ? Otherwise looks fine, Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs