Hi all, This series addresses a problem reported by Jan Beulich here: http://oss.sgi.com/pipermail/xfs/2016-February/047302.html The problem in this particular x86 vs. x86-64 case is that the size of some of the log data structures change due to padding (e.g., struct xlog_rec_header). The more general problem is that torn log write detection unconditionally scans behind an unmount record on a cleanly mounted filesystem, and thus can trip over log data that might not have been written by the currently running system. The solution implemented here is to limit torn write detection to when the log is dirty. Patches 1-3 refactor the existing code into some new helpers such that torn write detection can be made conditional. Patch 4 reorders the head/tail discovery logic to check for an unmount record at the head of the log and run torn write detection only when one is not present. This survives xfstests on x86-64, x86 and ppc64 boxes. I've also run the log test group against a test volume that was preserved and passed back and forth across all three of the aforementioned arches without a problem. Thoughts, reviews, flames appreciated. Brian Brian Foster (4): xfs: separate log head record discovery from verification xfs: refactor unmount record detection into helper xfs: refactor in-core log state update to helper xfs: only run torn log write detection on dirty logs fs/xfs/xfs_log_recover.c | 271 +++++++++++++++++++++++++++++------------------ 1 file changed, 168 insertions(+), 103 deletions(-) -- 2.4.3 _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
