On Tue, Mar 01, 2016 at 04:55:16AM -0800, Christoph Hellwig wrote: > On Mon, Feb 29, 2016 at 09:29:28AM -0500, Brian Foster wrote: > > Add a DEBUG mode-only sysfs knob to enable forced buffered write > > failure. An additional side effect of this mode is brute force killing > > of delayed allocation blocks in the range of the write. The latter is > > the prime motiviation behind this patch, as userspace test > > infrastructure requires a reliable mechanism to create and split > > delalloc extents without causing extent conversion. > > > > Certain fallocate operations (i.e., zero range) were used for this in > > the past, but the implementations have changed such that delalloc > > extents are flushed and converted to real blocks, rendering the test > > useless. > > Looks harmless, but I'd add a inline function to check for the failed > writes field so that we can compile it away entirely for !DEBUG builds. Good idea. The thought of burying this further down in get_blocks or somewhere around there has also crossed my mind since sending this, so I'll look into that as well. I'm mainly just curious whether it helps isolate the necessary changes any better than the current form... Brian _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
