On Wed, Feb 17, 2016 at 12:33:08AM -0800, Christoph Hellwig wrote: > On Wed, Feb 17, 2016 at 07:30:00PM +1100, Dave Chinner wrote: > > > Yeah, probably. I'll have to look at this a bit closer - I think I > > > assumed that we're always going to have v2 inode format here (like > > > we do in the kernel), but that may not be true. I'll have a closer > > > look. > > > > having a closer look, the XFS_SB_VERSION_NLINKBIT that is set here > > in sbversion is never used, so I just removed it. I also changed it > > back to using the converted in-memory link count so it's always > > going to be correct now. Now it is just: > > > > + setlink_inode(id, xino.i_d.di_nlink, type == DBM_DIR, security); > > Great. With that and the other nitpicks address: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > for the whole series. Thanks for the fast turnaround, Christoph! I'll get this pushed out in the morning.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
