On Tue, Feb 09, 2016 at 06:36:22PM +1100, Dave Chinner wrote: > On Mon, Feb 08, 2016 at 05:12:50PM -0800, Darrick J. Wong wrote: > > Create a couple of XFS-specific tests -- one to check that growing > > and shrinking the refcount btree works and a second one to check > > what happens when we hit maximum refcount. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > ..... > > +# real QA test starts here > > +_supported_os Linux > > +_supported_fs xfs > > +_require_scratch_reflink > > +_require_cp_reflink > .... > > + > > +test -x "$here/src/punch-alternating" || _notrun "punch-alternating not built" > > I suspect we need a _require rule for checking that something in > the test src directory has been built. Crapola, we also need punch-alternating, which doesn't appear until the next patch. Guess I'll go move it out of the next patch (or swap the order of these two I guess.) I added _require_test_program() which complains if src/$1 isn't built. > > +echo "Check scratch fs" > > +umount "$SCRATCH_MNT" > > +echo "check refcount after removing all files" >> "$seqres.full" > > +"$XFS_DB_PROG" -c 'agf 0' -c 'addr refcntroot' -c 'p recs[1]' "$SCRATCH_DEV" >> "$seqres.full" > > +"$XFS_REPAIR_PROG" -o force_geometry -n "$SCRATCH_DEV" >> "$seqres.full" 2>&1 > > +res=$? > > +if [ $res -eq 0 ]; then > > + # If repair succeeds then format the device so that the post-test > > + # check doesn't fail due to the single AG. > > + _scratch_mkfs >> "$seqres.full" 2>&1 > > +else > > + _fail "xfs_repair fails" > > +fi > > + > > +# success, all done > > +status=0 > > +exit > > This is what _require_scratch_nocheck avoids. > > i.e. do this instead: > > _require_scratch_nocheck > ..... > > "$XFS_REPAIR_PROG" -o force_geometry -n "$SCRATCH_DEV" >> "$seqres.full" 2>&1 > status=$? > exit Ok. > Also, we really don't need the quotes around these global > variables. They are just noise and lots of stuff will break if > those variables are set to something that requires them to be > quoted. <nod> --D > > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
