On Mon, Feb 08, 2016 at 01:42:39AM -0800, Christoph Hellwig wrote: > On Mon, Feb 08, 2016 at 03:24:21PM +1100, Dave Chinner wrote: > > - ASSERT(!(S_ISREG(ip->i_d.di_mode) && whichfork == XFS_DATA_FORK)); > > + ASSERT(!(S_ISREG(VFS_I(ip)->i_mode) && whichfork == XFS_DATA_FORK)); > > Maybe it's worth adding XFS_ISDIR/REG/.. helpers for all these checks? Makes sense - I think I'll do that as a followup patch, though, along with further icdinode cleanups. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
