This looks fine in general: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But: this now introduce struct inode to libxfs code, what's your plan to deal with that in xfsprogs? _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs