Re: [PATCH 4/7] libxfs: don't discard dirty buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -	xfs_buf_t		*bp = (xfs_buf_t *)node;
> +	struct xfs_buf		*bp = (struct xfs_buf *)node;

I'd much prefer to use container_of here (although it seems that
currently only exists under the name list_entry in xfsprogs).

But I guess that's better left for a later patch..

Otherwise looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs



[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux