On 2/4/16 6:04 PM, Eric Sandeen wrote: > Looks ok, but now with the new option: > > 1) needs a manpage update > 2) usage() should be updated to include -f So, I haven't quite worked out what this *is* doing, but on further reflection, it seems like "-f" should definitely relate to behavior which iterates over all filesystems. i.e. without -f, non-xfs filesystems are skipped; with -f, "foreign" filesystems are included. That was my main concern. But if an xfs_quota command is pointed directly at a non-xfs filesystem, I'm not sure what's best. Assume the user intended it, and operate on that fs w/o needing -f? Or require "-f" for consistency? What do you think? And, we can specify multiple mount points to operate on, i.e. xfs_quota -c "foo" /mnt/ext4 /mnt/xfs so ... I guess I don't know if that should require -f or not. principle of least surprise? Keep old behavior of ignoring the non-xfs mount? -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
