On Thu, Jan 28, 2016 at 05:16:56AM -0800, Christoph Hellwig wrote: > Any chance to get a review for this? It should really help > with sorting out the buffered I/O COW code. It looks reasonable to me. I separated the dio and buffered CoW remap paths a couple of weeks ago, because it seems that IO errors only get passed back as a return value from __blockdev_direct_IO, therefore the remapping has to be done from xfs_vm_do_dio anyway because we don't want to remap if the write fails. Just yesterday I removed the "is_cow" flag from the ioend, so now we're back to having a separate XFS_IO_COW ioend type. So... reflink doesn't need the patch but OTOH directio doesn't really need the overhead of allocating an ioend anyway. :) --D > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs