Re: [PATCH 3/4] xfstests: also treat EINVAL as reflink/dedup not supported

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 28, 2016 at 06:13:55PM +0100, Christoph Hellwig wrote:
> This can be returned by various implementations of the ioctl.

Looks reasonable, so
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

--D

> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  common/reflink | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/common/reflink b/common/reflink
> index de8e56d..8638aba 100644
> --- a/common/reflink
> +++ b/common/reflink
> @@ -92,6 +92,8 @@ _require_test_dedupe()
>  		_notrun "Dedupe not supported by test filesystem type: $FSTYP"
>  	echo $testio | grep -q "Inappropriate ioctl for device" && \
>  		_notrun "Dedupe not supported by test filesystem type: $FSTYP"
> +	echo $testio | grep -q "Invalid argument" && \
> +		_notrun "Dedupe not supported by test filesystem type: $FSTYP"
>  	rm -rf "$TEST_DIR/file1" "$TEST_DIR/file2"
>  }
>  
> @@ -110,6 +112,8 @@ _require_scratch_dedupe()
>  		_notrun "Dedupe not supported by test filesystem type: $FSTYP"
>  	echo $testio | grep -q "Inappropriate ioctl for device" && \
>  		_notrun "Dedupe not supported by test filesystem type: $FSTYP"
> +	echo $testio | grep -q "Invalid argument" && \
> +		_notrun "Dedupe not supported by test filesystem type: $FSTYP"
>  	_scratch_unmount
>  }
>  
> -- 
> 2.1.4
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs



[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux