On Sat, Jan 23, 2016 at 12:03:00PM -0600, Eric Sandeen wrote: > > > On 1/23/16 12:18 AM, Darrick J. Wong wrote: > > On Fri, Jan 22, 2016 at 10:55:52PM -0600, Eric Sandeen wrote: > >> On 1/22/16 6:35 PM, Darrick J. Wong wrote: > >>> Configure getopt to accept the -R argument to pwrite. > >> > >> Did you have anything against "F" and "B"? :) > >> > >> (They're missing too but in the case statements & help) > > > > No, but I /was/ wondering if the omission was deliberate? > > I don't think so; the commit that added it (8fb2237) > seemed to do everything but add the getopt chars. > > Oh, and however much gets fixed up, probably needs a man page > update too. The manpage already has -F/-B/-R, but you're right that I should add -F and -B to getopt. --D > > Thanks, > -Eric > > > --D > > > >> > >> -Eric > >> > >>> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > >>> --- > >>> io/pwrite.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> > >>> diff --git a/io/pwrite.c b/io/pwrite.c > >>> index fd9114d..c6efee9 100644 > >>> --- a/io/pwrite.c > >>> +++ b/io/pwrite.c > >>> @@ -259,7 +259,7 @@ pwrite_f( > >>> init_cvtnum(&fsblocksize, &fssectsize); > >>> bsize = fsblocksize; > >>> > >>> - while ((c = getopt(argc, argv, "b:Cdf:i:qs:S:uV:wWZ:")) != EOF) { > >>> + while ((c = getopt(argc, argv, "b:Cdf:i:qRs:S:uV:wWZ:")) != EOF) { > >>> switch (c) { > >>> case 'b': > >>> tmp = cvtnum(fsblocksize, fssectsize, optarg); > >>> > >>> _______________________________________________ > >>> xfs mailing list > >>> xfs@xxxxxxxxxxx > >>> http://oss.sgi.com/mailman/listinfo/xfs > >>> > >> > >> _______________________________________________ > >> xfs mailing list > >> xfs@xxxxxxxxxxx > >> http://oss.sgi.com/mailman/listinfo/xfs > > > > _______________________________________________ > > xfs mailing list > > xfs@xxxxxxxxxxx > > http://oss.sgi.com/mailman/listinfo/xfs > > > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs