Looks great! Reviewed-by: Christoph Hellwig <hch@xxxxxx> Note that the "if (*tpp != tp)" trick also works in xfs_bmap_finish, which will allows us to fold __xfs_trans_roll into xfs_trans_roll in a follow on patch. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs