On Mon, Dec 21, 2015 at 05:31:11PM +1100, Dave Chinner wrote: > On Sat, Dec 19, 2015 at 01:11:31AM -0800, Darrick J. Wong wrote: > > Add more tests for unaligned copy-on-write things, and explicitly > > test the ability to pass "len == 0" to mean reflink/dedupe all > > the way to the end of the file". > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > ..... > > +_cleanup() > > +{ > > + cd / > > + rm -rf "$tmp".* "$TESTDIR" > > +} > ..... > > + > > +TESTDIR="$TEST_DIR/test-$seq" > > +rm -rf "$TESTDIR" > > +mkdir "$TESTDIR" > > This use of TESTDIR is highly confusing. When I see TESTDIR I think > that it's the mount point of the test device, not potentially some > directory on the scratch device. > > I see that this occurs through lots of tests, not just these new > ones. Can you do a pass across the tests with, say, sed and rename > all these to something less confusing? e.g. "testdir", in lower > case, makes it clear that it's a local variable, not the global test > device mount point.... (i.e. test local variables are lower case, > exported test harnes variables are upper case ;) > > Separate patch/pull req is fine. No problem. Will give it a spin on the test harness before sending. (Yikes, it's a 272K patch...) --D > > Cheers, > > dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs