Re: [PATCH 35/76] libxfs: refactor short btree block verification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +/**
> + * xfs_btree_sblock_v5hdr_verify() -- verify the v5 fields of a short-format
> + *				      btree block
> + *
> + * @bp: buffer containing the btree block
> + * @max_recs: pointer to the m_*_mxr max records field in the xfs mount
> + * @pag_max_level: pointer to the per-ag max level field
> + */

We're so far avoided using kerneldoc comments and they silly super
verbosity in XFS.  It might be good to tone this down to the normal
XFS level (same for some other patches).

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs



[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux