On 12/13/15 7:01 PM, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Arkadiusz Miskiewicz reported that metadump was crashing on one of > his corrupted filesystems, and the trace indicated that it was > zeroing unused regions in inode btree blocks when it failed. The > btree block had a corrupt nrecs field, which was resulting in an out > of bounds memset() occurring. Doh. Time to run fuzzers+valgrind w/ metadump I guess... /me looks at djwong ... > Ensure that the region being generated for zeroing is within bounds > before executing the zeroing. While there, abstract the repeated > boiler plate code so that it is simpler to maintain and extend the > zeroing code to new types of btrees in future. yeah, thanks, not sure why I didn't do that originally. Much better. Might be nice to split the bugfix & the cleanup into 2 patches, though... Thanks, -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
