For the series: Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> I think we caught everything! ;) Thanks, -Eric On 10/2/15 11:22 AM, Bill O'Donnell wrote: > > Hello- > > Following is the next iteration of the series to add per-fs xfs stats to > sysfs. > > ----------history--------------- > v10: > -style fixups in patches 1,4,5,7 > > v9: > -adjust individual patch content, so that fixes actually correspond > to reviews accordingly. > > -fix xfs_btree.h XFS_BTREE_STATS_ADD macro error made in patch 7. > -fix xfs_stats.h macro style errors made in patch 7 > > > v8: (add patches 6 and 7) > -patch 6: per-filesystem stats in sysfs. > Implement per-filesystem stats objects in sysfs. Stats objects are > instantiated when an xfs filesystem is mounted and deleted on unmount. > With this patch, the stats directory is created and populated with > the familiar stats and stats_clear files. > Example: > /sys/fs/xfs/sda9/stats/stats > /sys/fs/xfs/sda9/stats/stats_clear > > With this patch, the individual counts within the new per-fs > stats file(s) remain at zero. Functions that use the the macros > to increment, decrement, and add-to the per-fs stats counts will > be covered in the next patch (7). > > -patch 7: per-filesystem stats counter implementation > Modify the stats counting macros and the callers > to those macros to properly increment, decrement, and add-to > the xfs stats counts. The counts for global and per-fs stats > are correctly advanced, and cleared by writing a "1" to the > corresponding clear file. > > global counts: /sys/fs/xfs/stats/stats > per-fs counts: /sys/fs/xfs/sda*/stats/stats > > global clear: /sys/fs/xfs/stats/stats_clear > per-fs clear: /sys/fs/xfs/sda*/stats/stats_clear > > v7: > add patch 5/5: incorporate sysfs/kobject in xfsstats: handlers > take kobjects. Allocate & deallocate per-fs stats structures > and set up the sysfs entries for them. Add kobject and a pointer > to a per-cpu struct xfsstats. Modify the macros that manipulate > the stats accordingly. > > v6: > -move to_xlog(kobject) to the relevant show/store operations. > This keeps the xfs_sysfs_object_show/store functions generic. > Also, with the change, there can be some cleanup of the > show/store function arguments. > > v5: > -optimization of sysfs_ops function. > -style fixups > > v4: > -add patch 4 (sysfs ops consolidation - dbg, stats, log) > > v3: > -style fixups. > > v2: > -style fixups. > v1: > -------------------------------- > > We already have per-fs information in /sys, so it makes sense to > have per-fs stats there too. The series moves existing > global stats infrastructure to /sys and reuses that code to > create per-fs stats in /sys. > > Patch 1 handles the bring-up and tear down of xfs/stats directory > structure in sysfs when an fs is mounted. The directory contains > the stats file and the stats_clear file. The stats file contents mimic > those of /proc/fs/xfs/stat. The stats_clear file is empty, and much > like the current stat_clear command, handles the zeroing of the stats > file when a "1" is echoed to the stats_clear file. > > Patch 2 creates the symlink for stats from procfs to sysfs. > > Patch 3 removes the now unused portions of procfs for stat. > > Patch 4 consolidates the sysfs ops for dbg, stats, log. > > Patch 5 allocates and deallocates per-fs stats structures and > sets up the sysfs entries for them. Add kobject and a pointer > to a per-cpu struct xfsstats. Modify the macros that manipulate > > Patch 6 implements per-filesystem stats objects in sysfs. Stats > objects are instantiated when an xfs filesystem is mounted and > deleted on unmount. > > Patch 7 modifies the stats counting macros and the callers > to those macros to properly increment, decrement, and add-to > the xfs stats counts. The counts for global and per-fs stats > are correctly advanced, and cleared by writing a "1" to the > corresponding clear file. > > Once again, comments and questions are welcome. > > Thanks- > Bill > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs > _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
