On Fri, Sep 04, 2015 at 03:13:49PM -0500, Eric Sandeen wrote: > On 9/4/15 7:55 AM, Bill O'Donnell wrote: > > Currently, xfs global stats are in procfs. This patch introduces > > (replicates) the global stats in sysfs. Additionally a stats_clear file > > is introduced in sysfs. > > > > Signed-off-by: Bill O'Donnell <billodo@xxxxxxxxxx> > > > > +STATIC ssize_t > > +xfs_stats_store( > > + struct kobject *kobject, > > + struct attribute *attr, > > + const char *buf, > > + size_t count) > > still have some spaces after the types, before the vars... > > Otherwise, this looks good to me; it's not the only place we have > missing tabs... *shrug* you could resend, or maybe Dave's willing > to fix up on commit. Nah. I'll fix it and resubmit. Thanks again for the review ;) -Bill > > Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> > > Thanks, > -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
