Re: [PATCH v2] xfsprogs: add nftw64 translation for OS X

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Tue, Sep 1, 2015 at 6:31 PM, Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote:
On Tue, Sep 01, 2015 at 10:04:32AM +0200, Jan Tulak wrote:
> UPDATE: changed to #define
>
> OS X has only nftw variant - not the 64 suffix used in xfs.
>
> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx>
> ---
>  include/darwin.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/darwin.h b/include/darwin.h
> index 72d9c1d..f0f05b3 100644
> --- a/include/darwin.h
> +++ b/include/darwin.h
> @@ -157,6 +157,8 @@ typedef int64_t           xfs_daddr_t;
>
>  #define HAVE_FID     1
>
> +#define nftw64 nftw
> +

Sorry for chiming in late, but there's only one caller of nftw64 and several
callers of nftw; why not just change it to use nftw?

<shrug> There could be other reasons why xfs_estimate requires the -64
variant, but I don't know. :)

​Good idea. I'll run tests after the change​
 
​and if nothing bad happens, I send
it here.
--
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux