Re: [PATCH] xfs: add mssing inode cache attempts counter increment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 27, 2015 at 09:04:21PM +0200, Lucas Stach wrote:
> Increasing the inode cache attempt counter was apparently dropped while
> refactoring the cache code and so stayed at the initial 0 value. Add the
> increment back to make the runtime stats more useful.
> 
> Signed-off-by: Lucas Stach <dev@xxxxxxxxxx>
> ---

Heh, this goes back to:

	bf90424 [XFS] Combine the XFS and Linux inodes

... from 2008. :)

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

>  fs/xfs/xfs_icache.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 76a9f27..0a326bd 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -412,6 +412,8 @@ xfs_iget(
>  	if (!ino || XFS_INO_TO_AGNO(mp, ino) >= mp->m_sb.sb_agcount)
>  		return -EINVAL;
>  
> +	XFS_STATS_INC(xs_ig_attempts);
> +
>  	/* get the perag structure and ensure that it's inode capable */
>  	pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ino));
>  	agino = XFS_INO_TO_AGINO(mp, ino);
> -- 
> 2.4.3
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs



[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux