On 7/15/15 6:16 AM, Brian Foster wrote: > On Wed, Jul 15, 2015 at 10:16:08AM +0200, Jan Kara wrote: >> xfs_alloc_fix_freelist() can sometimes jump to out_agbp_relse without >> ever setting value of 'error' variable which is then returned. This can >> happen e.g. when pag->pagf_init is set but AG is for metadata and we >> want to allocate user data. >> >> Fix the problem by initializing 'error' to 0, which is the desired >> return value when we decide to skip this group. >> >> CC: xfs@xxxxxxxxxxx >> Coverity-id: 1309714 >> Signed-off-by: Jan Kara <jack@xxxxxxxx> >> --- > > Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx> Dave, ping on this one? I don't see it in your latest update, looks important. (xfsprogs has the same problem, FWIW) -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
