On Wed, Aug 19, 2015 at 10:09 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Wed, Aug 19, 2015 at 07:45:57AM +1000, Dave Chinner wrote:
> > Hmmm, looks like I accidentally comitted an earlier version of this
> > patch yesterday. Jan, can you send delta patches to what I committed
> > to address more recent review comments? Sorry, my bad.
I guess my chaotic versioning can be blamed. :-)
> Can you revert it for now? I think most of these changes are incorrect
I agree, revert seems like a better idea. Especially if we want to split things
like removing the XATTR_ dependency move into standalone commits.
> and should either be dropped for now by disabling fsx
I proposed dropping some tools earlier, but there was a valid point about
the possibility to break something when not even trying to compile it.
i.e. with the XATTR_ -> XFS_XATTR mentioned in the first reply to this patch
(which I already moved to a separate patch), it is necessary to add
#include "xfs/xfs_arch.h"
#include "xfs/xfs_format.h"
into libhandle/handle.c. But
in fsr and fsr wasn't compiling, I would most likely send a patch which would
be thrown
So I think
at all
> or will need
Working on it. :-)
Cheers,
Jan
--
Jan Tulak
jtulak@xxxxxxxxxx / jan@xxxxxxxx
>
> On Wed, Aug 19, 2015 at 07:45:57AM +1000, Dave Chinner wrote:
> > Hmmm, looks like I accidentally comitted an earlier version of this
> > patch yesterday. Jan, can you send delta patches to what I committed
> > to address more recent review comments? Sorry, my bad.
I guess my chaotic versioning can be blamed. :-)
> Can you revert it for now? I think most of these changes are incorrect
I agree, revert seems like a better idea. Especially if we want to split things
like removing the XATTR_ dependency move into standalone commits.
> and should either be dropped for now by disabling fsx
I proposed dropping some tools earlier, but there was a valid point about
the possibility to break something when not even trying to compile it.
i.e. with the XATTR_ -> XFS_XATTR mentioned in the first reply to this patch
(which I already moved to a separate patch), it is necessary to add
#include "xfs/xfs_arch.h"
#include "xfs/xfs_format.h"
into libhandle/handle.c. But
I found
this
when I tried to compile it. If it wasin fsr and fsr wasn't compiling, I would most likely send a patch which would
be thrown
back
on my head immediately. ;-)So I think
it is better to have "bad dummy stuff" than not compile itat all
.> or will need
a major rework.Working on it. :-)
Cheers,
Jan
--
Jan Tulak
jtulak@xxxxxxxxxx / jan@xxxxxxxx
_______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
