Re: [PATCH v4 09/11] xfsprogs: Add mntent.h check into autoconf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 17, 2015 at 5:04 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
This looks mostly fine.  I think you could just add the
AC_CHECK_HEADERS directly to configure.ac, but otherwise it's exactly
what I though.
 
In configure.ac, there are no direct checks for headers, just calls of all the various
AC_HAVE_*. I'm not sure it is a good idea to mix now. Unless you think that all
the functions should be moved into configure.ac from the m4/ directory.

 
Can you please resend all your pending patches in a single series,
and move the UPDATES: lines and other internal changelogs to the
cover letter instead of the patch descriptions?

Thanks for doing this work!

Sure, I'll send it again as a whole. And np. :-)

--
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux