On Thu, Aug 06, 2015 at 01:44:22PM -0400, Brian Foster wrote: - __xfs_efi_release(efip); + xfs_efi_release(efip); Can you explain in the changelog why this is safe? > -xfs_efi_release(xfs_efi_log_item_t *efip, > - uint nextents) > +xfs_efi_release(struct xfs_efi_log_item *efip) Can you use normal XFS function formatting here? e.g. xfs_efi_release( struct xfs_efi_log_item *efip) As a follow on we should be able to remove atomic_inc_return and replace it with a local iterator in xfs_bmap_finish(). _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs