Hi all, This is another quick RFC related to testing issues I'm hitting with my previously posted log recovery fixes. Patch 1 is a small refactor to support patch 2. Patch 2 describes the issues I'm hitting in repeated shutdown and log recovery testing. This passes some spot testing and seems to resolve the hang from the test sequence described in the commit log description, but more testing is definitely required. I _think_ I follow the log callbacks and how the EFI/EFD are expected to be managed, but I could easily be missing something. As it is, I'm off for a long weekend after today so I'm sending this to hopefully get some eyes to sanity check before I get too deep into testing this along with the previous fixes next week... Brian Brian Foster (2): xfs: return committed status from xfs_trans_roll() xfs: fix efi/efd error handling to avoid fs shutdown hangs fs/xfs/xfs_bmap_util.c | 35 ++++++++++++++++++++-------- fs/xfs/xfs_extfree_item.c | 59 +++++++++++++++++++++++++---------------------- fs/xfs/xfs_trans.c | 15 ++++++++++-- fs/xfs/xfs_trans.h | 1 + 4 files changed, 71 insertions(+), 39 deletions(-) -- 2.1.0 _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs