Thanks Jan! On Thu, Jul 02, 2015 at 12:43:16PM +0200, Jan Tulak wrote: > Because blkid is here for a long time, I hereby propose a patch for removing support > for NOT having blkid. The current support through set of #ifdef is prone to errors like > making a patch just in one of the branches, and according to a recent talk between > Christoph and Eric, it is not necessary to keep it supported. > > Remove code for checking ENABLE_BLKID, and the code when ENABLE_BLKID is not defined. > The only use of libdisk was in the removed code, so remove libdisk too. > It makes blkid required for compilation. Can you wrap your commit description lines after ~ 75 characters, please? > +AC_HAVE_BLKID_TOPO(yes) I don't think we'll need an unused argument for AC_HAVE_BLKID_TOPO. > -Mac OS X Instructions > -===================== Why do you remove this section? > > default: depend $(LTCOMMAND) > > -ifneq ($(ENABLE_BLKID),yes) > -default: $(FSTYP) > -endif > - > include $(BUILDRULES) > > -$(FSTYP): > - @echo " [CC] $@" > - $(Q)$(LTLINK) $@.c -o $@ $(CFLAGS) $(LDFLAGS) $(LIBDISK) $(PLDLIBS) > - Please remove fstyp.c and the definition of FSTYP in the Makefile as well. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
