On Wed, Jul 01, 2015 at 06:01:01PM +0200, Jan Tulak wrote: > Because blkid is here for a long time, I hereby propose a patch for removing support > for NOT having blkid. The current support through set of #ifdef is prone to errors like > making a patch just in one of the branches, and according to a recent talk between > Christoph and Eric, it is not necessary to keep it supported. > > Remove code for checking ENABLE_BLKID, and the code when ENABLE_BLKID is not defined. > It makes blkid required for compilation. > > Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx> > --- > Makefile | 5 ---- > configure.ac | 6 +---- > doc/INSTALL | 44 ------------------------------------ > include/builddefs.in | 1 - > libdisk/Makefile | 4 ---- > m4/package_blkid.m4 | 7 +++--- > mkfs/Makefile | 21 ++++------------- > mkfs/xfs_mkfs.c | 64 ---------------------------------------------------- > 8 files changed, 10 insertions(+), 142 deletions(-) Given that only mkfs.xfs uses libdisk, which is now not linked to any binary, shouldn't libdisk/ be removed completely? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
