----- Original Message ----- > From: "Christoph Hellwig" <hch@xxxxxxxxxxxxx> > To: "Jan ??ul??k" <jtulak@xxxxxxxxxx> > Cc: "Dave Chinner" <dchinner@xxxxxxxxxx>, xfs@xxxxxxxxxxx > Sent: Friday, June 19, 2015 1:10:22 PM > Subject: Re: [PATCH 01/17] xfsprogs: use common code for multi-disk detection > > > index 70e43a0..3269ec3 100644 > > --- a/include/Makefile > > +++ b/include/Makefile > > @@ -26,9 +26,15 @@ QAHFILES = libxfs.h libxlog.h \ > > xfs_inode.h \ > > xfs_log_recover.h \ > > xfs_metadump.h \ > > + xfs_mkfs.h \ > > xfs_mount.h \ > > + xfs_quota_defs.h \ > > + xfs_sb.h \ > > + xfs_shared.h \ > > xfs_trace.h \ > > - xfs_trans.h > > + xfs_trans.h \ > > + xfs_trans_resv.h \ > > + xfs_trans_space.h > > These shouldn't be added to the headers installed by make install-qa. > > (which I'm going to send a patch to remove once Dave applied the > build fix, btw) > OK, noted. > Also I'm not sure xfs_mkfs.h really is a good name for a global header. I don't see any issue with it, but if there is a reason for a different name, I can change it. :-) Cheers, Jan -- Jan Tulak jtulak@xxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
