Hi all, This is a small cleanup series for some of the repair code touched by the sparse inode chunks feature, in response to review comments in the following thread: http://oss.sgi.com/archives/xfs/2015-06/msg00053.html It primarily creates a few helper functions for hunks of code executed multiple times or code that is common between the increasingly similar but separate inobt and finobt record scanning code. For much of the latter code, the only difference between the separate functions is the error message output to indicate which tree is affected by a problem. Therefore, I abstracted out the inobt name and factored out some helpers that can perform the appropriate checks regardless of the tree type. This series is purely cleanup and should not alter functionality in any way. Thoughts? Brian Brian Foster (4): repair: access helpers for on-disk inobt record freecount repair: helper for inode chunk alignment and start/end ino number verification repair: helper to import on-disk inobt records to in-core trees repair: helper to transition inode blocks to inode state repair/dino_chunks.c | 91 ++++++------- repair/incore.h | 28 ++++ repair/phase5.c | 12 +- repair/scan.c | 377 +++++++++++++++++++++++++-------------------------- 4 files changed, 259 insertions(+), 249 deletions(-) -- 1.9.3 _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
