On Wed, May 06, 2015 at 03:53:49PM +1000, Dave Chinner wrote: > On Wed, May 06, 2015 at 03:43:10PM +1000, Dave Chinner wrote: > > On Tue, May 05, 2015 at 09:36:36PM -0700, Christoph Hellwig wrote: > > > This looks reasonable, but I miss Ccs to the authors of the > > > percpu_counter code and linux-kernel. > > > > linux-kernel was cc'd. > > > > > On Wed, May 06, 2015 at 08:01:38AM +1000, Dave Chinner wrote: > > > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > > > > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > > > And this looks wrong, too :) > > > > That looks like a change of tool behaviour. I just upgraded guilt; > > the old version stripped "from" lines in patch descriptions from the > > git commit log as goes into the author field of the commit. The new > > version does not appear to strip the from lines, and so when > > git-send-email formats it, it puts a from line in the message, and > > then the commit message has one too. > > Ok, so I remembered it the wrong way around, but it is a tool bug: > > $ guilt patchbomb -s d480578..cd83c77 > cd83c773 xfs: inode counter needs to use __percpu_counter_compare > 1e41b5ad percpu_counter: batch size aware __percpu_counter_compare() > Are these what you want to send? [Y/n] > .... > > Note the use of "-s". from the man page: > > -s > Don't add additional repository committer sign-offs to > the patch. This allows the sign-off chain to be fully > expressed in the commit messages and not changed by the > act of sending a patchbomb. > > It would appear that the "-s" option is not working properly. I'll > fix that before sending the next round of patches.... <sigh> So, the packaged version of guilt on a brand new debian unstable installation is actually older than the 2 year version of guilt I had previously installed and used on a different machine. IOWs, the debian distro version has this bug in it: http://repo.or.cz/w/guilt.git?a=commit;h=8f88f953580a0cacf111bf64c0e838014ee30c01 Yeah, that was fixed more than 3 years ago. Oh well, back to using a locally installed version... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
