On Tue, May 05, 2015 at 04:16:28PM -0400, Nicholas Krause wrote: > This makes the function,xfs_alloc_lookup_eq static as there are no > calls to this function outside the definition file for this function, > xfs_alloc.c. > > Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx> > --- > fs/xfs/libxfs/xfs_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c > index 516162b..48de3f0 100644 > --- a/fs/xfs/libxfs/xfs_alloc.c > +++ b/fs/xfs/libxfs/xfs_alloc.c > @@ -52,7 +52,7 @@ STATIC int xfs_alloc_ag_vextent_small(xfs_alloc_arg_t *, > /* > * Lookup the record equal to [bno, len] in the btree given by cur. > */ > -STATIC int /* error */ > +static int /* error */ > xfs_alloc_lookup_eq( > struct xfs_btree_cur *cur, /* btree cursor */ > xfs_agblock_t bno, /* starting block of extent */ Please have a look at what STATIC actually means, and then use the sparse checker to confirm that these functions are already static for a CONFIG_XFS_DEBUG=n build. i.e. STATIC is a stack usage minimisation and debugging aid, not something that is broken and needs fixing. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
