On Fri, Apr 24, 2015 at 08:29:42AM +1000, Dave Chinner wrote: > On Thu, Apr 23, 2015 at 09:07:43PM +0200, Christoph Hellwig wrote: > > We can use the generic symlink in pagecache code for XFS non-inline > > symlinks. Because links are always shorter than a page we will > > get the zero termination for the link for free. > > Doesn't work for v5 filesystems where headers and CRCs are embedded > into the same blocks as the symlink data. i.e. this now falls down > to ->readpage to read the link data into the page cache, and that > just reads the entire blocks into the page cache. So what we can end > up within the page cache is this: Uh, ok. Guess the pagecache symlink support isn't too useful then. I'll respin to only optimize the inline symlinks, which should still we worthwhile. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
