On Tue, Mar 24, 2015 at 02:08:36PM +0200, Boaz Harrosh wrote: > On 03/24/2015 12:51 PM, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Add the initial support for DAX file operations to XFS. This > > includes the necessary block allocation and mmap page fault hooks > > for DAX to function. > > > > Note: we specifically have to disable splice_read/write from > > It looks from below code that splice_read is perfectly supportable > through the call to default_file_splice_read() so you might > want to change the comment here. Ah, I forgot to update the description. > Regarding splice_write: > It looks to me like you left the vector at iter_file_splice_write(). > If I understand correctly I think you need to call default_file_splice_write() > that uses memcpy, just as it was at the previous patches when you left > the vector NULL. So I think you need the same switch for write > as you do below for read. iter_file_splice_write() uses vfs_iter_write, which goes through ->write_iter, which we punt to the direct IO path for DAX. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
