On 3/9/15 12:24 PM, Rui Gomes wrote:
> Hello Eric,
>
> I would love to send you the xfs metadump but it segfaults as well.
woohoo! \o/
> This is the output of xfs_repair truncated:
>
...
> no . entry for directory 260215042
> no .. entry for directory 260215042
> problem with directory contents in inode 260215042
> would have cleared inode 260215042
> bad nblocks 7 for inode 260256256, would reset to 0
> bad nextents 1 for inode 260256256, would reset to 0
> entry " kchnfig" in shortform directory 260256256 references invalid inode 28428972647780227
> entry contains illegal character in shortform dir 260256256
> would have junked entry "kchnfig" in directory inode 260256256
> entry " " in shortform directory 260256256 references invalid inode 0
> size of last entry overflows space left in in shortform dir 260256256, would reset to -1
> *** buffer overflow detected ***: /usr/sbin/xfs_repair terminated
Ok, looking at the sheer number of errors, I really wonder what happened to the fs.
You''d do well to be 100% sure that storage is OK, and that you're not trying to
repair a filesytem on scrambled disks but in any case, xfs should not segfault.
But anyway, this:
> size of last entry overflows space left in in shortform dir 260256256, would reset to -1
is a good clue; it must be in here:
if (i == num_entries - 1) {
namelen = ino_dir_size -
((__psint_t) &sfep->name[0] -
(__psint_t) sfp);
do_warn(
_("size of last entry overflows space left in in shortform dir %" PRIu64 ", "),
ino);
if (!no_modify) {
do_warn(_("resetting to %d\n"),
namelen);
sfep->namelen = namelen;
*dino_dirty = 1;
which means the -1 namelen memmove choked on came from:
ino_dir_size - ((__psint_t) &sfep->name[0] - (__psint_t) sfp);
and those come from:
sfp = (struct xfs_dir2_sf_hdr *)XFS_DFORK_DPTR(dip) = ((char *)dip + xfs_dinode_size(dip->di_version))
ino_dir_size = be64_to_cpu(dip->di_size);
sfep = ... xfs_dir2_sf_firstentry(sfp);
We could just be defensive against a negative namelen, but maybe we should
understand a bit more clearly how we got here.
Might start by trying:
# xfs_db -c "inode 260256256" -c "p" /dev/whatever
and show us what you get.
-Eric
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
