On Mon, Mar 02, 2015 at 10:56:14PM -0800, Linus Torvalds wrote: > On Mon, Mar 2, 2015 at 9:20 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > >> > >> But are those migrate-page calls really common enough to make these > >> things happen often enough on the same pages for this all to matter? > > > > It's looking like that's a possibility. > > Hmm. Looking closer, commit 10c1045f28e8 already should have > re-introduced the "pte was already NUMA" case. > > So that's not it either, afaik. Plus your numbers seem to say that > it's really "migrate_pages()" that is done more. So it feels like the > numa balancing isn't working right. So that should show up in the vmstats, right? Oh, and there's a tracepoint in migrate_pages, too. Same 6x10s samples in phase 3: 3.19: 55,898 migrate:mm_migrate_pages And a sample of the events shows 99.99% of these are: mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason= 4.0-rc1: 364,442 migrate:mm_migrate_pages They are also single page MIGRATE_ASYNC events like for 3.19. And 'grep "numa\|migrate" /proc/vmstat' output for the entire xfs_repair run: 3.19: numa_hit 5163221 numa_miss 121274 numa_foreign 121274 numa_interleave 12116 numa_local 5153127 numa_other 131368 numa_pte_updates 36482466 numa_huge_pte_updates 0 numa_hint_faults 34816515 numa_hint_faults_local 9197961 numa_pages_migrated 1228114 pgmigrate_success 1228114 pgmigrate_fail 0 4.0-rc1: numa_hit 36952043 numa_miss 92471 numa_foreign 92471 numa_interleave 10964 numa_local 36927384 numa_other 117130 numa_pte_updates 84010995 numa_huge_pte_updates 0 numa_hint_faults 81697505 numa_hint_faults_local 21765799 numa_pages_migrated 32916316 pgmigrate_success 32916316 pgmigrate_fail 0 Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
