Seems a little pointless, but given that we overload these different operations over ->rename making Coverity happy might not be the worst idea. Maybe we should just add a different ->rename_exchange methods given that there's not much shared code anywhere. Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs