Re: [PATCH] xfs: Introduce permanent async buffer write IO failures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/19/15 8:28 AM, Brian Foster wrote:
> On Thu, Feb 19, 2015 at 09:32:20AM +1100, Dave Chinner wrote:

...

>> +	if (!(bp->b_flags & (XBF_STALE|XBF_WRITE_FAIL))) {
>> +		bp->b_flags |= XBF_WRITE | XBF_ASYNC |
>> +			       XBF_DONE | XBF_WRITE_FAIL;
>> +		xfs_buf_submit(bp);
>> +		return true;

so, shouldn't

		xfs_buf_ioerror(bp, 0);

go under this conditional to address Brian's point... ok, you just responded to that. :)

FWIW, this is re-setting XBF_ASYNC which must already be set, right?
 
-Eric

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux