Re: [PATCH 4/4] xfsprogs: Adding XFS_IOC_FIEMAPFS ioctl for use in xfs_spaceman

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 11, 2015 at 3:49 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> On Thu, Jan 29, 2015 at 07:01:02PM +0530, Dhruvesh Rathore wrote:
>>
>> This patch is concerned with the changes to be done in userspace code for
>> turning FS_IOC_FIEMAPFS present in the earlier version of xfs_spaceman
>> into an XFS specific ioctl called XFS_IOC_FIEMAPFS, which uses all existing
>> fiemap insfrastructure.
>> By introducing XFS_IOC_FIMEAPFS ioctl, it can be seperated from file based
>> fiemap commands and allows us to review it and push it as we need, making the
>> process much simpler.
> .....
>>  typedef struct histent
>> @@ -201,9 +201,9 @@
>>               fiemap->fm_length = length;
>>               fiemap->fm_extent_count = NR_EXTENTS;
>>
>> -             ret = ioctl(file->fd, FS_IOC_FIEMAPFS, (unsigned long)fiemap);
>> +             ret = xfsctl(file->name,file->fd, XFS_IOC_FIEMAPFS, (unsigned long)fiemap);
>>               if (ret < 0) {
>   ^
> Patch hunk is corrupt: it is missing the leading whitespace to
> indicate "no change on this line".
>
> I've fixed it up to apply the patch.
>
> -Dave.

We again apologize for the constant white space errors. We will surely make
use of the various git commands that you have mentioned to ensure that we
send clean patches.
Thank you for reworking and applying the patches :)

Regards,
A-DRS

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux