On Mon, Feb 02, 2015 at 10:04:03AM +1100, Dave Chinner wrote:
> > A nit, but I guess you could kill the braces here now too.
>
> Given it's a multi-line return statement, the braces are fine. FWIW,
> when we have a if () { return ...} else { return ... } we normally
> kill the else. i.e:
>
> if (rw & WRITE) {
> return foo(
> bar,
> baz);
> }
> return .....;
>
> So I modified it like this.
For an if/else that is 100% symmetric like read vs write I prefer
to keep the else, otherwise I agree. But in the end it's a very
minor point, so it doesn't really matter.
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
