Hi Jan, These three patches detect and fix the issues you reported with log recovery finding buffers with a format type of zero. The type of zero (XFS_BLFT_UNKNOWN_BUF) is only valid for buffers that have been cancelled (i.e. invalidated or marked stale as they have been freed), so the series adds asserts to ensure these conditions are met during transaction commit. Hence we shouldn't ever get new code that fails to set the buffer type getting through testing. The last two patches fix the cases that running xfstests uncovered where we don't set the buffer type appropriately. There may be more, but doing this much made my head hurt and xfstests is clean, so it's as much as I'm going to do right now. Can you test it and see if it runs clean (with CONFIG_XFS_WARN=y or CONFIG_XFS_DEBUG=y) on your test setup? Cheers, Dave. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
