Re: [PATCH 1/3] xfs: Remove useless test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu 15-01-15 08:27:54, Brian Foster wrote:
> On Thu, Jan 15, 2015 at 11:18:03AM +0100, Jan Kara wrote:
> > Q_XQUOTARM is never passed to xfs_fs_set_xstate() so remove the test.
> > 
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > ---
> 
> Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
  Thanks for reviews! I've pulled the XFS cleanups from this series into my
tree.
								Honza

> >  fs/xfs/xfs_quotaops.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
> > index 7542bbeca6a1..8fcd20dbf89a 100644
> > --- a/fs/xfs/xfs_quotaops.c
> > +++ b/fs/xfs/xfs_quotaops.c
> > @@ -75,7 +75,7 @@ xfs_fs_set_xstate(
> >  
> >  	if (sb->s_flags & MS_RDONLY)
> >  		return -EROFS;
> > -	if (op != Q_XQUOTARM && !XFS_IS_QUOTA_RUNNING(mp))
> > +	if (!XFS_IS_QUOTA_RUNNING(mp))
> >  		return -ENOSYS;
> >  
> >  	if (uflags & FS_QUOTA_UDQ_ACCT)
> > -- 
> > 2.1.2
> > 
> > _______________________________________________
> > xfs mailing list
> > xfs@xxxxxxxxxxx
> > http://oss.sgi.com/mailman/listinfo/xfs
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs



[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux