> +static void xfs_qm_fill_state(struct qc_type_state *tstate, Normal xfs style would be to keep the "static void " on a separate line, as well as the arguments, e.g. static void xfs_qm_fill_state( struct qc_type_state *tstate, > > + struct xfs_mount *mp, > + struct xfs_inode *ip, > + xfs_ino_t ino) No need to pass mp, as it can be derived as ip->i_mount. Btw, I think this code should move into xfs_quotaops.c now that it ties into the Linux quota interface, and xfs_qm_scall_getstate should be folded into xfs_fs_get_quota_state. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
