On Thu 04-12-14 14:37:09, Al Viro wrote: > On Thu, Dec 04, 2014 at 02:27:36PM +0100, Jan Kara wrote: > > WARN_ON in inode_set_mask() warns if we don't clear all bits we are > > setting instead of reverse - warning when caller requests setting and > > clearing of the same bit. > > WTF? 'mask' is "all bits we are asked to modify", 'flags' - "the values to > put into those bits". Have you even looked at the callers, let alone > tested it? Sorry, I misunderstood how the function is supposed to work. Discard this patch please. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
