Hi folks, I noticed a bit of inconsistency when reviewing the shift extent return cleanups that coccinelle flagged. The first was that the out_error labels were basically meaningless - it jsut returns the error, and we have much neater ways of doing that. Also, the logic flow through xfs_bmse_shift_one() jumped around all over the place - it can be done lots neater without any gotos at all, and is easier to read as a result. These patches apply on top of the for-next branch (the xfs-coccinelle-cleanups branch to be precise). Cheers, Dave. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs