On Tue 04-11-14 07:40:20, Jan Beulich wrote: > >>> On 03.11.14 at 23:18, <david@xxxxxxxxxxxxx> wrote: > > On Mon, Nov 03, 2014 at 04:41:13PM +0000, Jan Beulich wrote: > >> having run into that warning too, I looked into it a little, and now > >> having found that patch am pretty uncertain: Both truncate_setsize() > >> and pagecache_isize_extended() document that they want to be > >> called with i_mutex held, so removing the WARN_ON() alone seems > >> either incomplete or wrong. What I found to work without violating > >> this documented requirement is the patch below. > > > > Or, just perhaps, the comments are wrong.... > > Right - that's what I was suggesting with the option of the patch > being incomplete (rather than just removing the WARN_ON() it > should also remove the respective comments then). Yeah, I'll update the comments to mention there are filesystem which use serialization different from i_mutex. Thanks for catching this. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
